GSoC progress for week #2.
Disabling slide sorter shorcuts when in edit mode / Impress
- Bug: tdf#98404 - UX - While objects on a slide are being edited, notably text boxes, the new slide sorter Ctrl+Shift shortcut combinations (see bug 91909) incorrectly receive focus and move the slide.
In Impress, when editing a text on a slide, CTRL+SHIFT+(HOME/END/ArrowUP/ArrowDOWN) shortcuts doesn’t select the text in the slide, but move the slide to the end of the slide stack.
Solution is simple: Disable slide sorter shortcuts when in text edit mode.
This week I tried to disable slide sorter shortcuts while in edit mode. However, I couldn’t found a proper way to disable them.
edit mode in ./sd/source/ui/func/futext.cxx:1034: https://opengrok.libreoffice.org/xref/core/sd/source/ui/func/futext.cxx?r=9090dc1f#1034
SID_MOVE_PAGE_UP (LAST/DOWN/FIRST) state methods calls in: https://opengrok.libreoffice.org/xref/core/sfx2/source/control/shell.cxx?r=a3d89265#492
ExecMethod / StateMethod: https://opengrok.libreoffice.org/xref/core/sd/sdi/SlideSorterController.sdi?r=951b243f#311
In FuText:SetInEditMode, We should disable the global slide sorting shortcuts by something like:
… However, none of them are worked, and I don’t know if there is another way to make SIDs disable while in edit mode. Since we are in the GSoC period, I don’t want to waste my time with a bug that I couldn’t make progress. I will look again this bug after GSoC with a huge free time!.
- Look tdf#98404 later. (most likely after GSoC)
- Commented on bug page: https://bugs.documentfoundation.org/show_bug.cgi?id=98404#c25